refactor(rbgs): init rbgs apiVersion v1alpha2#173
refactor(rbgs): init rbgs apiVersion v1alpha2#173Syspretor wants to merge 1 commit intosgl-project:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the RoleBasedGroupSet API by introducing a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the v1alpha2 API version for RoleBasedGroupSet and related types. This includes new type definitions, and all the necessary auto-generated client-go code (clientsets, informers, listers, applyconfigurations).
My main concern is that v1alpha1 is marked as the storage version, but there are significant structural differences between v1alpha1 and the new v1alpha2 API, and no conversion logic has been implemented. This is a critical issue that will lead to data loss and prevent the CRD from being correctly updated and used. I've left a detailed comment on this.
Please address this by implementing the required conversion webhooks.
| // +kubebuilder:object:root=true | ||
| // +kubebuilder:subresource:status | ||
| // +kubebuilder:subresource:scale:specpath=.spec.replicas,statuspath=.status.replicas | ||
| // +kubebuilder:storageversion |
There was a problem hiding this comment.
By marking v1alpha1 as the storage version, you are establishing it as the hub for API conversions. The newly introduced v1alpha2 version has significant structural differences compared to v1alpha1, particularly in RoleBasedGroupSpec and RoleSpec.
For example:
v1alpha1.RoleBasedGroupSpeccontainsPodGroupPolicyandCoordinationRequirements, which are absent inv1alpha2.RoleBasedGroupSpec.v1alpha1.RoleSpecusesTemplateSource,TemplatePatch, andLeaderWorkerSetdirectly, whilev1alpha2.RoleSpecrefactors this into an inlinedPatternstruct withStandalonePatternandLeaderWorkerPattern.
Without implementing conversion webhooks, these structural differences will lead to data loss when converting between versions. For example, if a user creates a v1alpha1 resource with PodGroupPolicy and then retrieves it as v1alpha2, that field will be lost.
You need to implement the conversion.Hub and conversion.Convertible interfaces for the v1alpha1 and v1alpha2 types respectively to handle the conversion between these versions. Please add the conversion logic as part of this PR to ensure data integrity across API versions.
1 participant
Ⅰ. Motivation
Ⅱ. Modifications
Ⅲ. Does this pull request fix one issue?
fixes #XXXX
Ⅳ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅴ. Describe how to verify it
VI. Special notes for reviews
Checklist
make fmt.